only set disableRemotePlayback if it's defined by the browser

canalplus · Nov 6, 2024 · 6571e83 · 6571e83
1 parent e2e3399
commit 6571e83
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/src/core/stream/representation/representation_stream.ts b/src/core/stream/representation/representation_stream.ts
@@ -213,7 +213,7 @@ export default function RepresentationStream<TSegmentDataType>(
   const canStream = new SharedReference<boolean>(true);
 
   playbackObserver.listen((observation) => {
-    const observationCanStream = observation.canStream ?? true
+    const observationCanStream = observation.canStream ?? true;
     if (canStream.getValue() !== observationCanStream) {
       log.debug("Stream: observation.canStream updated to", observationCanStream);
       canStream.setValue(observationCanStream);

diff --git a/src/experimental/tools/VideoThumbnailLoader/prepare_source_buffer.ts b/src/experimental/tools/VideoThumbnailLoader/prepare_source_buffer.ts
@@ -69,7 +69,7 @@ export default function prepareSourceBuffer(
         resetMediaElement(videoElement, objectURL);
       });
     }
-    if (isManagedMediaSource) {
+    if (isManagedMediaSource && "disableRemotePlayback" in videoElement) {
       const disableRemotePlaybackPreviousValue = videoElement.disableRemotePlayback;
       cleanUpSignal.register(() => {
         /**
@@ -78,7 +78,6 @@ export default function prepareSourceBuffer(
          * by the application before calling the RxPlayer.
          */
         if (
-          "disableRemotePlayback" in videoElement &&
           disableRemotePlaybackPreviousValue !== undefined
         ) {
           videoElement.disableRemotePlayback = disableRemotePlaybackPreviousValue;

diff --git a/src/main_thread/init/multi_thread_content_initializer.ts b/src/main_thread/init/multi_thread_content_initializer.ts
@@ -1814,7 +1814,7 @@ export default class MultiThreadContentInitializer extends ContentInitializer {
               });
               mediaSourceStatus.setValue(MediaSourceInitializationStatus.Attached);
 
-              if (isManagedMediaSource) {
+              if (isManagedMediaSource && "disableRemotePlayback" in mediaElement) {
                 const disableRemotePlaybackPreviousValue =
                   mediaElement.disableRemotePlayback;
                 this._currentMediaSourceCanceller.signal.register(() => {
@@ -1824,7 +1824,6 @@ export default class MultiThreadContentInitializer extends ContentInitializer {
                    * before calling the RxPlayer.
                    */
                   if (
-                    "disableRemotePlayback" in mediaElement &&
                     disableRemotePlaybackPreviousValue !== undefined
                   ) {
                     mediaElement.disableRemotePlayback =

diff --git a/src/main_thread/init/utils/create_media_source.ts b/src/main_thread/init/utils/create_media_source.ts
@@ -80,7 +80,7 @@ function createMediaSource(
   resetMediaElement(mediaElement, oldSrc);
   const mediaSource = new MainMediaSourceInterface(generateMediaSourceId());
 
-  if (isManagedMediaSource) {
+  if (isManagedMediaSource && "disableRemotePlayback" in mediaElement) {
     const disableRemotePlaybackPreviousValue = mediaElement.disableRemotePlayback;
     unlinkSignal.register(() => {
       /**
@@ -89,7 +89,6 @@ function createMediaSource(
        * by the application before calling the RxPlayer.
        */
       if (
-        "disableRemotePlayback" in mediaElement &&
         disableRemotePlaybackPreviousValue !== undefined
       ) {
         mediaElement.disableRemotePlayback = disableRemotePlaybackPreviousValue;