Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands for force failover to a region #509

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Conversation

deepthidevaki
Copy link
Contributor

Related to https://github.com/camunda/zeebe-e2e-test/issues/421

This PR adds commands for

  1. Force failover to one region zbchaos forceFailover --regions=2 --regionId=1
    • Removes region 0 and keeps the brokers from region 1
  2. And adding the region back zbchaos scale --brokers=4 --replicationFactor=4
    • Re-uses the scale command, and added the parameter replicationFactor

The commands are manually tested on a benchmark cluster.

Also adds an optional awaitReadiness flag to dataloss recover command. When using the new API for failover, all brokers in the failed region must be started in parallel. Waiting for one broker to be ready before the others are started can prevent the failback from completing.

Awaiting pod readiness can be added as a seperate step in the chaos tests.
To reuse this command for failback in 2-region test, we are removing thsi
from the command. During failback, the brokers in the other region will not
be ready until the scale up is completed.
@deepthidevaki deepthidevaki requested review from npepinpe and removed request for ChrisKujawa March 11, 2024 11:07
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively approve, I think we need to sync before I fully understand, since I missed adding the API endpoint and so on

@deepthidevaki deepthidevaki merged commit e96c047 into main Mar 12, 2024
3 checks passed
@deepthidevaki deepthidevaki deleted the dd-force-scale-down branch March 12, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants