fix: publish message with 1h ttl #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages were published with a TTL of 5 minutes, which means the engine buffers them for 5 minutes. The buffered message is then expected to correlate to a process instance's event later in the chaos experiment. However, in some cases, the chaos experiment takes longer than these 5 minutes. When the message is expired, the chaos experiment can no longer succeed even though it retries for an hour. For example, this occurred in the action: - Should be able to create a process instance and await the message correlation Changing the TTL of the published message fixes this problem by buffering the message for the same duration as the retry period.
ChrisKujawa
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Awesome! Thank you very much @korthout that you looked into it and fixed it! Great stuff! 🚀
I was think whether there was any explanation why it was 5 minute, so I searched the git history. I just found this f9adf47 I remember before I had no TTL which is in go per default zero (I think) and also failed the experiments. With 5 minutes I think it most of the time just worked. But yes makes sense to me to increase this a bit more to be more reliable 👍🏼
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages were published with a TTL of 5 minutes, which means the engine buffers them for 5 minutes. The buffered message is then expected to correlate to a process instance's event later in the chaos experiment.
However, in some cases, the chaos experiment takes longer than these 5 minutes. When the message is expired, the chaos experiment can no longer succeed even though it retries for an hour. For example, this occurred in the action:
Changing the TTL of the published message fixes this problem by buffering the message for the same duration as the retry period.