Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiments need to start with lower letter #264

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Experiments need to start with lower letter #264

merged 1 commit into from
Dec 2, 2022

Conversation

ChrisKujawa
Copy link
Member

Set json annotation to marshal the experiments into correct key, with small letters.

@ChrisKujawa
fix: experiments need to start with lower letter
3bf09d6 
Set json annotation to marshal the experiments into correct key, with small letters.
@ChrisKujawa
Copy link
Member Author

This causes right now several incidents in our QA runs.

deepthidevaki
deepthidevaki approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChrisKujawa ChrisKujawa merged commit bfa8312 into main Dec 2, 2022
@ChrisKujawa ChrisKujawa deleted the zell-fix-read-exp branch December 2, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthidevaki deepthidevaki deepthidevaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisKujawa @deepthidevaki