Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New tests for worker #257

Merged
merged 4 commits into from
Nov 25, 2022
Merged

New tests for worker #257

merged 4 commits into from
Nov 25, 2022

Conversation

ChrisKujawa
Copy link
Member

  • Move logic of worker into own package.
    • For better encapsulation and testability
  • Write new tests for job worker/handler

@ChrisKujawa
refactor: move worker code
1686394 
Move worker code into own package, for better encapsulation and testing purposes.
@ChrisKujawa
test: write new tests for worker code
92f8b5a
lenaschoenburg
lenaschoenburg approved these changes Nov 24, 2022
View reviewed changes
Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like the refactoring, just one minor comment

go-chaos/worker/chaos_worker.go Outdated Show resolved Hide resolved
@ChrisKujawa
refactor: remove global func pointer
c67cc7e 
Replace global func pointer with parameter in handle method
@ChrisKujawa ChrisKujawa merged commit 1c6ea0c into main Nov 25, 2022
@ChrisKujawa ChrisKujawa deleted the zell-worker branch November 25, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaschoenburg lenaschoenburg lenaschoenburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisKujawa @lenaschoenburg