Improve current state #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move functions to make scope clearer and easier to find
lenaschoenburg
approved these changes
Nov 15, 2022
| @@ -27,21 +27,39 @@ import ( | |||
|
|
|||
| func (c K8Client) ApplyNetworkPatch() error { | |||
There was a problem hiding this comment.
💭
Nice that you got this working for SaaS too. I think the only thing missing would be to pause reconciliation. Same for all other functionality that modifies any of the resources managed by the ZeebeCluster CRD.
There was a problem hiding this comment.
Jep right now it is only this I think the other stuff is inside the container like disconnecting
npepinpe
reviewed
Nov 15, 2022
| "k8s.io/client-go/util/retry" | ||
| ) | ||
|
|
||
| func (c K8Client) PauseReconciliation() error { |
There was a problem hiding this comment.
❓ Is there something we could link as documentation for how reconciliation works?
There was a problem hiding this comment.
There was a problem hiding this comment.
Maybe we could add that for future people who may not know where this is defined (in case it needs to change) 🙃
|
Thanks for the review 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be seen as preparation for working on disconnect gateways.
Don't get scared by the number of lines. It is mostly moving code and adding new tests.