feat: add backup take and backup wait commands
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenaschoenburg
force-pushed
the
os-zbchaos-backup
branch
from
857242f to
89d96a2
Compare
|
@npepinpe ping? :) |
npepinpe
approved these changes
Oct 21, 2022
| rootCmd.AddCommand(backupCommand) | ||
|
|
||
| backupCommand.AddCommand(takeBackupCommand) | ||
| takeBackupCommand.Flags().StringVar(&backupId, "backupId", strconv.FormatInt(time.Now().UnixMilli(), 10), "optionally specify the backup id to use, uses the current timestamp by default") |
There was a problem hiding this comment.
🔧 Unless we plan to have commands without the flag, it could simply be on the general backupCommand, and the child commands will inherit it I think.
| } | ||
|
|
||
| port := 9600 | ||
| closePortForward, err := k8Client.GatewayPortForward(port, port) |
There was a problem hiding this comment.
💭 I think almost everywhere we act the same (e.g. panic when we can't port forward). Wondering if it's useful to have it return an error at all, or if we should just have a function MustForwardGatewayPort which returns either a close function or explodes anyway.
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two commands that allow taking a backup and waiting for a backup to complete or fail