Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix allowedIn for zeebe:LoopCharacteristics #66

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

philippfromme
Copy link
Contributor

zeebe:LoopCharacteristics isn't restricted to certain flow elements but to bpmn:MultiInstanceLoopCharacteristics. This is also how it's validated by the engine.


Related to camunda/camunda-modeler#4310

@nikku
Copy link
Member

nikku commented Oct 30, 2024

@philippfromme And we do read the "allowedIn" from nested elements? Otherwise this will now break. To date only diagram elements (their business object types) are in allowedElements, cf. check.

@barmac
Copy link
Collaborator

barmac commented Oct 31, 2024

If I understand this correctly, the copyPasteBehavior checks the ancestor elements regardless if they are flow elements or not, cf. https://github.com/camunda/camunda-bpmn-js-behaviors/blob/main/lib/camunda-cloud/CopyPasteBehavior.js#L84
What I'd suggest though is to have an accompanying pull request on camunda-bpmn-js-behaviors to verify the fix in an integration test.

@nikku
Copy link
Member

nikku commented Oct 31, 2024

Thanks @barmac for the context. Looks good to me then. ✔️

@philippfromme
Copy link
Contributor Author

Integration test: camunda/camunda-bpmn-js-behaviors#84

@philippfromme philippfromme merged commit 05d4b4d into main Oct 31, 2024
3 checks passed
@philippfromme philippfromme deleted the fix-loop-characteristics branch October 31, 2024 10:27
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants