Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/arm python #168

Merged
merged 19 commits into from
Mar 4, 2024
Merged

Feature/arm python #168

merged 19 commits into from
Mar 4, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Mar 1, 2024 •
edited
Loading

closes #167

@leiicamundi leiicamundi requested a review from Langleu March 1, 2024 17:36
@leiicamundi leiicamundi self-assigned this Mar 1, 2024
@leiicamundi
Copy link
Contributor Author

Too many commits; I'll squash and merge when this PR is reviewed

@leiicamundi leiicamundi marked this pull request as ready for review March 1, 2024 17:37
Langleu
Langleu reviewed Mar 4, 2024
View reviewed changes
common-tooling/action.yml Outdated Show resolved Hide resolved
Langleu
Langleu reviewed Mar 4, 2024
View reviewed changes
common-tooling/action.yml Outdated Show resolved Hide resolved
Langleu
Langleu reviewed Mar 4, 2024
View reviewed changes
common-tooling/action.yml Outdated Show resolved Hide resolved
Langleu
Langleu requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@leiicamundi leiicamundi requested a review from Langleu March 4, 2024 09:15
@leiicamundi
Copy link
Contributor Author

leiicamundi commented Mar 4, 2024 •
edited
Loading

@Langleu, changes have been applied following your request:

  • Updated the list of self-runners and incorporated the use of the aws-arm runner in the test pipeline.
  • Improved documentation to emphasize arm-specific options in Python (including incompatible ones).
  • Fixed conditions for the installation of Python on ARM.

Langleu
Langleu approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work 🚀

@leiicamundi leiicamundi merged commit e577a32 into main Mar 4, 2024
5 checks passed
@leiicamundi leiicamundi deleted the feature/arm-python branch March 4, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Langleu Langleu Langleu approved these changes

Assignees

@leiicamundi leiicamundi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python Installation Failure on ARM Architecture
2 participants
@leiicamundi @Langleu