Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inbound metrics #678

Merged
merged 2 commits into from
Jun 6, 2023
Merged

feat: inbound metrics #678

merged 2 commits into from
Jun 6, 2023

Conversation

chillleader
Copy link
Member

@chillleader chillleader commented Jun 6, 2023

Description

In this PR I added new metrics for inbound connectors and slightly refined the existing metrics.

  • Count inbound activations, deactivations, triggers as well as trigger outcomes, plus imported process definitions.
  • The semantics of inbound metrics were changes:
    • Previously activated metric related to connector trigger events.
    • Now it is related to connector instance activations/deactivations, and triggers are recorded separately.

⚠️ Depends on camunda-community-hub/spring-zeebe#440

Grafana dashboard will follow in another PR.

Related issues

closes https://github.com/camunda/team-connectors/issues/290

@@ -11,3 +11,7 @@ camunda.operate.client.url=http://localhost:8081
camunda.operate.client.username=demo
camunda.operate.client.password=demo
camunda.connector.webhook.enabled=true

management.server.port=9080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: we will also need to update Helm charts: https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform/templates/connectors/deployment.yaml#L131

Created a task here so that we don't forget.

I'll fix it closer to release or when I have time. Alternatively, you can fix that too, and I can help you with testing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good point. I will try to fix this if I have the time until I'm off, otherwise I will let you know.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chillleader Do we have to introduce this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not really. If it makes us change the Helm charts, we can leave it as is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chillleader ok, just maybe don't commit on much time. For me it will take ~2-3 hours.

Also, camunda-platform will also need this change reflected. https://github.com/camunda/camunda-platform/blob/main/docker-compose.yaml#L151

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this port change altogether so that we don't have to change the Helm charts.

igpetrov
igpetrov previously approved these changes Jun 6, 2023
@chillleader chillleader merged commit d8f029c into main Jun 6, 2023
@chillleader chillleader deleted the inbound-metrics branch August 3, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants