-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inbound metrics #678
Conversation
@@ -11,3 +11,7 @@ camunda.operate.client.url=http://localhost:8081 | |||
camunda.operate.client.username=demo | |||
camunda.operate.client.password=demo | |||
camunda.connector.webhook.enabled=true | |||
|
|||
management.server.port=9080 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: we will also need to update Helm charts: https://github.com/camunda/camunda-platform-helm/blob/main/charts/camunda-platform/templates/connectors/deployment.yaml#L131
Created a task here so that we don't forget.
I'll fix it closer to release or when I have time. Alternatively, you can fix that too, and I can help you with testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good point. I will try to fix this if I have the time until I'm off, otherwise I will let you know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chillleader Do we have to introduce this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, not really. If it makes us change the Helm charts, we can leave it as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chillleader ok, just maybe don't commit on much time. For me it will take ~2-3 hours.
Also, camunda-platform
will also need this change reflected. https://github.com/camunda/camunda-platform/blob/main/docker-compose.yaml#L151
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this port change altogether so that we don't have to change the Helm charts.
Description
In this PR I added new metrics for inbound connectors and slightly refined the existing metrics.
activated
metric related to connector trigger events.Grafana dashboard will follow in another PR.
Related issues
closes https://github.com/camunda/team-connectors/issues/290