-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(twilio inbound): add inbound connector #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, few suggestions
connectors/twilio/element-templates/twilio-webhook-connector.json
Outdated
Show resolved
Hide resolved
connectors/twilio/element-templates/twilio-webhook-connector.json
Outdated
Show resolved
Hide resolved
"type": "Hidden", | ||
"value": "disabled", | ||
"binding": { | ||
"type": "zeebe:property", | ||
"name": "inbound.shouldValidateHmac" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does Twilio have any security mechanism?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now I can't use it, but in twilio documentation, it exists. I will chat with Twilio support. I created a new task with it. #551
fd15a71
to
43262f0
Compare
Description
Add Twilio inbound connector
Related issues
closes #
#480