Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(twilio inbound): add inbound connector #541

Merged
merged 1 commit into from
May 8, 2023

Conversation

Oleksiivanov
Copy link
Contributor

@Oleksiivanov Oleksiivanov commented May 4, 2023

Description

Add Twilio inbound connector

Screenshot 2023-05-05 at 01 51 12

Related issues

closes #

#480

@Oleksiivanov Oleksiivanov self-assigned this May 4, 2023
@Oleksiivanov Oleksiivanov linked an issue May 4, 2023 that may be closed by this pull request
@Oleksiivanov Oleksiivanov added the scope:twilio Twilio connector label May 4, 2023
@Oleksiivanov Oleksiivanov requested review from sbuettner and igpetrov May 5, 2023 08:29
@Oleksiivanov Oleksiivanov marked this pull request as ready for review May 5, 2023 08:29
@Oleksiivanov Oleksiivanov requested a review from a team as a code owner May 5, 2023 08:29
Copy link
Contributor

@igpetrov igpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few suggestions

Comment on lines +58 to +63
"type": "Hidden",
"value": "disabled",
"binding": {
"type": "zeebe:property",
"name": "inbound.shouldValidateHmac"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Twilio have any security mechanism?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I can't use it, but in twilio documentation, it exists. I will chat with Twilio support. I created a new task with it. #551

@Oleksiivanov Oleksiivanov force-pushed the 480-implement-inbound-twilio-connector branch from fd15a71 to 43262f0 Compare May 8, 2023 08:00
@Oleksiivanov Oleksiivanov merged commit b2ced9a into main May 8, 2023
@Oleksiivanov Oleksiivanov deleted the 480-implement-inbound-twilio-connector branch May 8, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:twilio Twilio connector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement inbound Twilio Connector
3 participants