feat(box-connector): Box Connector #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuettner
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
connectors/box/src/main/java/io/camunda/connector/box/BoxUtil.java
Dismissed
Show dismissed
Hide dismissed
sbuettner
force-pushed
the
958-box-connector
branch
from
bf43ae7 to
54dfde6
Compare
github-actions
bot
temporarily deployed
to
connectors-958-box-connect-c8sm
sbuettner
force-pushed
the
958-box-connector
branch
from
54dfde6 to
5f5d8a5
Compare
github-actions
bot
temporarily deployed
to
connectors-958-box-connect-c8sm
sbuettner
requested review from
mathias-vandaele and
johnBgood
and removed request for
johnBgood
github-actions
bot
temporarily deployed
to
connectors-958-box-connect-c8sm
github-actions
bot
temporarily deployed
to
connectors-958-box-connect-c8sm
github-actions
bot
temporarily deployed
to
connectors-958-box-connect-c8sm
github-actions
bot
temporarily deployed
to
connectors-958-box-connect-c8sm
mathias-vandaele
approved these changes
Dec 24, 2024
| defaultValue = "developerToken", | ||
| description = | ||
| "Specify authentication strategy. Learn more at the <a href=\"https://developer.box.com/guides/authentication/\" target=\"_blank\">documentation page</a>") | ||
| public sealed interface Authentication |
There was a problem hiding this comment.
Authentication interface could be in another file for readability
There was a problem hiding this comment.
I prefer to have the whole request in a single file. Maybe a matter of taste
There was a problem hiding this comment.
I tend to agree with @mathias-vandaele here, I feel it helps when navigating code
| name = "type", | ||
| defaultValue = "createFolder", | ||
| description = "The operation to execute.") | ||
| public sealed interface Operation |
There was a problem hiding this comment.
Same, it could be separated for readability
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Box.com Connector
Related issues
https://github.com/camunda/team-connectors/issues/958
Related epic
https://github.com/camunda/product-hub/issues/2399
Checklist
no milestonelabel.