Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish templates with -version qualifier #17

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Oct 13, 2022

Description

Ensures we publish templates with a -$version qualifier.

Example: If slack-connector.json has a .version field THEN we rename it to slack-connector-$version.json.

Gracefully handles missing version (does not rename).
Gracefully handles templates packed as arrays (we should get rid of these).

Related issues

Related to https://github.com/camunda/team-connectors/issues/170

@nikku nikku requested review from menski and tmetzke October 13, 2022 22:36
@nikku nikku force-pushed the template-version-qualifier branch from cc24910 to 2ec8f7d Compare October 14, 2022 09:41
@nikku nikku requested a review from tmetzke October 14, 2022 09:42
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Let's try it and otherwise fix it :shipit:

@nikku nikku merged commit 8bff9b7 into main Oct 14, 2022
@nikku nikku deleted the template-version-qualifier branch October 14, 2022 09:43
@nikku
Copy link
Member Author

nikku commented Oct 14, 2022

We gotta somehow get a version into our connector templates. Anyone @camunda/connectors-dev wants to take a stab at it? 😉

chillleader pushed a commit that referenced this pull request Dec 5, 2022
…th-0.x

chore(deps): update google-github-actions/auth action to v0.7.0
chillleader pushed a commit that referenced this pull request Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants