feat: customize URL of Google Tag Manager #4369
Conversation
pepopowitz
added
the
dx
| // ["@edno/docusaurus2-graphql-doc-generator", | ||
| // { | ||
| // schema: "http://localhost:8080/tasklist/graphql", | ||
| // rootPath: "./docs/", // docs will be generated under (rootPath/baseURL) | ||
| // baseURL: "apis-tools/tasklist-api", | ||
| // linkRoot: "/docs/", | ||
| // loaders: { | ||
| // UrlLoader: "@graphql-tools/url-loader" | ||
| // } | ||
| // }, | ||
| // ], |
There was a problem hiding this comment.
I don't know what this is or why were holding on to it, but I've been meaning to delete this for a long time 😅
docusaurus.config.js
Outdated
| id: "GTM-KQGNSTS", // GTM Container ID | ||
| containerId: "GTM-KQGNSTS", | ||
| tagManagerUrl: | ||
| process.env.TAG_MANAGER_URL || "https://ssgtm.camunda.com", |
There was a problem hiding this comment.
I'm letting the default value flow through for now; if we decide in the future that we want to change it again, we can do so by specifying an environment variable in GitHub.
| if (process.env.NODE_ENV !== "production") { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This will prevent GTM from rendering when running locally. The plugin we're previously using doesn't do this, but it seems like the right thing to do.
My anxiety appreciates this. |
There was a problem hiding this comment.
I'm not really sure how to test this, but I see it loads the URL, so I will approve.
@antantunes, would you be able to confirm this change is working as expected? Does this change need to go in parallel with the product? AFAIK, they have not received a request for this.
|
Removing |
akeller
added
deploy
|
Followed up via Slack https://camunda.slack.com/archives/C034F8NA1G8/p1728315795888939 |
pepopowitz
deleted the
pepopowitz/4351-request-change-url-of-google-tag-manager
branch
|
🧹 Preview environment for this PR has been torn down. |
Description
Addresses #4351.
Uninstalls the 3rd-party plugin we were using (https://github.com/LukasGentele/docusaurus-gtm-plugin), and defines the plugin locally instead, with the ability to specify a
tagManagerUrl.When should this change go live?
PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).My changes require an Engineering review, and I've assigned the Engineering DRI or delegate.
My changes require a technical writer review, and I've assigned @camunda/tech-writers as a reviewer.
My changes require a docs infrastructure review.