chore: rewrite Footer customization based on docusaurus 2.0.0-rc.1 #1114
Conversation
pepopowitz
added
component:docs
|
|
||
| function FooterLink({ to, href, label, prependBaseUrlToHref, ...props }) { |
There was a problem hiding this comment.
One nice thing about newer versions of docusaurus -- they made it easier to "wrap" theme components, which allowed us to delete a lot of this file.
| .footerLogoLink { | ||
| opacity: 0.5; | ||
| transition: opacity 0.15s ease-in-out; | ||
| } | ||
|
|
||
| .footerLogoLink:hover { | ||
| opacity: 1; | ||
| } |
There was a problem hiding this comment.
These first two styles are from the classic theme, we can delete them because the theme takes care of them for us.
| /* Osano Styles */ | ||
|
|
||
| .osano-cm-widget svg { | ||
| display: none; | ||
| } | ||
| .osano-cm-widget svg { | ||
| display: none; | ||
| } | ||
| .osano-cm-widget:focus, | ||
| .osano-cm-widget:hover { | ||
| opacity: 1; | ||
| transform: none; | ||
| } | ||
| .osano-cm-widget:active { | ||
| transform: translateY(1px); | ||
| } | ||
| .osano-cm-link { | ||
| color: #002f66 !important; | ||
| } | ||
| .osano-cm-close { | ||
| background: transparent !important; | ||
| } | ||
| .osano-cm-view--type_consent .osano-cm-list-item:nth-child(5) { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
These Osano styles are for the consent popup, but the ones that are actually used are in src/custom.css.
There was a problem hiding this comment.
Visual proof that there is no regression in the consent popup due to removing these styles:
I say regression because @akeller raised concerns that the styles in the code do not match the styles given to us by marketing, which I will follow up on (and will not block the merge of this PR).
There was a problem hiding this comment.
This was my 🗑️, but I followed up with you on Slack about some discrepancies and to check in with the web marketing team. This doesn't block this PR.
There was a problem hiding this comment.
I see no blocking issues and the CSS performs as expected. Thanks for cleaning this up! I love PRs that delete more than they add!!!
Regarding styles - Button styling is different on docs vs. camunda.com to match the respective button experience. Please don't change this because consistency should match the experience of the site.
The link is also a different color than I would expect.
|
That is by far the worst and laziest screenshot I've taken in my life, and I'd just like to apologize to the internet by letting everyone know I'm signing off for the day. |
|
Merging, and I'll deal with the cookie consent styling difference(s) in a follow-up. |
…amunda#1114) * docs: add a description of the theme folder and some best practices for customizing * docs: explain when & why ColorModeToggle was swizzled * chore: remove unused gtag.js file * chore: rewrite external link icon so that it's a straight swizzle * chore: rewrite footer to swizzle current version of docusaurus
Partially addresses #1024
In the process of updating docusaurus in #1024, our customized Footer component became out-of-date. This PR rewrites that component based on the correct source, with no functional changes.
It includes a few other small tangential details:
src/themefolder describing what lives theredocusaurus-gtm-plugin)Proof that the footer hasn't changed
Follow-up