Support Spring Boot 3.2

[ThorbenLindhauer]

User Story (Required on creation)

• As a software developer, I can build an application with the Camunda Spring Boot starter that uses Spring Boot 3.2

Functional Requirements (Required before implementation)

• Spring Boot is updated to 3.2 on the master branch so that it comes as the default Spring Boot versions when a dependency to the Camunda starter is declared
• Backporting and compatibility for 7.20 similarly how we did it here https://github.com/camunda/camunda-bpm-platform-maintenance/commit/f836e86e6ab881756d7877904da5987aed90e823

Technical Requirements (Required before implementation)

• The Camunda Spring Boot starter is technically compatible with Spring Boot 3.2
• On 7.20, Run distribution is packaged with Spring Boot 3.2

Limitations of Scope

Hints

• Spring Boot 3.2 also updates Snakeyaml to 2.0 (via Upgrade to SnakeYAML 2.0 spring-projects/spring-boot#35982)
• The target release date for Spring Boot 3.2.0 is currently 23rd of November

Links

• https://jira.camunda.com/browse/SEC-217
• https://jira.camunda.com/browse/SEC-245
• https://jira.camunda.com/browse/SEC-808
• https://jira.camunda.com/browse/SUPPORT-19797
• Spring Boot 3.2 Release Notes
• Centralize Selenium Version to parent pom.xml #4020

Breakdown

camunda-bpm-platform PR

Preview Give feedback

1. Try out spring boot 3.2 #4006
   bot:java-dependency-check ci:run ci:spring-boot +3
   

camunda-bpm-platform-ee PR

Preview Give feedback

1. https://github.com/camunda/camunda-bpm-platform-ee/pull/879

camunda-bpm-platform-maintenance | Backport PR - 7.20

Preview Give feedback

1. https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1124
2. https://github.com/camunda/camunda-bpm-platform-maintenance/pull/1158

camunda-bpm-platform-ee-maintenance | Backport PR - 7.20

Preview Give feedback

1. https://github.com/camunda/camunda-bpm-platform-ee-maintenance/pull/451
2. https://github.com/camunda/camunda-bpm-platform-ee-maintenance/pull/456

camunda-docs-manual

Preview Give feedback

1. docs(spring-boot-integration): Update Spring Boot Matrix camunda-docs-manual#1578
   +0
   
2. docs(spring-boot-integration): Update Spring Boot Matrix camunda-docs-manual#1577
   +0
   

Dev2QA handover

• Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment

[psavidis]

Update 12 Dec

• The build failures on Jenkins when Upgrading to Spring Boot 3.2 are highly related to a Regression bug of Spring 6+ combined with Spring Boot versions > 3.1.5

• The Jenkin Builds passed with Spring Boot 3.2 and Latest changes for Selenium

Next Steps:

• License Check Verification
• Backport Spring Boot 3.2 to 7.20 Release; the default Spring Boot version remains 3.1, but we have dedicated CI test stages that allow us to ensure compatibility with Spring Boot 3.2
  • Similar task has been done here

[zambrovski]

Hi folks,

org.camunda.bpm.spring.boot.starter.actuator.ProcessEngineHealthIndicator which can't be deactivated, uses org.springframework.util.Assert.notNull(processEngine) in its constructor. This deprecated method was marked for deprecation and is removed in Spring 6.1.

As a result is:

Description:

An attempt was made to call a method that does not exist. The attempt was made from the following location:

    org.camunda.bpm.spring.boot.starter.actuator.ProcessEngineHealthIndicator.<init>(ProcessEngineHealthIndicator.java:29)

The following method did not exist:

    'void org.springframework.util.Assert.notNull(java.lang.Object)'

The calling method's class, org.camunda.bpm.spring.boot.starter.actuator.ProcessEngineHealthIndicator, was loaded from the following location:

    jar:file:/home/simon/.m2/repository/org/camunda/bpm/springboot/camunda-bpm-spring-boot-starter/7.20.2-ee/camunda-bpm-spring-boot-starter-7.20.2-ee.jar!/org/camunda/bpm/spring/boot/starter/actuator/ProcessEngineHealthIndicator.class

The called method's class, org.springframework.util.Assert, is available from the following locations:

    jar:file:/home/simon/.m2/repository/org/springframework/spring-core/6.1.1/spring-core-6.1.1.jar!/org/springframework/util/Assert.class

The called method's class hierarchy was loaded from the following locations:

    org.springframework.util.Assert: file:/home/simon/.m2/repository/org/springframework/spring-core/6.1.1/spring-core-6.1.1.jar

In contrast to that, the org.camunda.bpm.spring.boot.starter.actuator.JobExecutorHealthIndicator is using java.util.Objects.requireNonNull(jobExecutor) which works fine.

The fix of this would be trivial - do you want me to provide a PR?

Cheers,

Simon

[zambrovski]

The Assert class from Spring states in the docs pretty clear and uses all means to indicate this removal:

	/**
	 * Assert that an object is not {@code null}.
	 * @deprecated as of 4.3.7, in favor of {@link #notNull(Object, String)};
	 * to be removed in 6.1
	 */
	@Deprecated(forRemoval = true)
	public static void notNull(@Nullable Object object) {
		notNull(object, "[Assertion failed] - this argument is required; it must not be null");
	}

[psavidis]

Hey @zambrovski ,

After checking out the latest code of camunda-bpm-platform in this branch, JobExecutorHealthIndicator uses the notNull method with the two parameters (including the message) which is as you pointed out the one that survived (the deprecated one is already removed when upgrading to spring boot 3.2 and spring 6.1.1 to that extend).

[tasso94]

@psavidis, PRs look good. Feel free to merge.

[stefanzilske]

Hey, any date when 7.20.3 with Support for SpringBoot 3.2 will be released?

BR, Stefan

[tasso94]

Hi @stefanzilske,

7.20.3 is scheduled for the end of January.

Best,
Tassilo

[psavidis]

Updated the Spring Boot Compatibility Matrix in Documentation to match the latest Spring Boot 3.2 Support. Closing the ticket.

[yanavasileva]

Reopening the ticket:

• On 7.20, Distro Run should be shipped with Spring Boot 3.2. I will adjust the ticket description too.

[psavidis]

Reopening the ticket:

• On 7.20, Distro Run should be shipped with Spring Boot 3.2. I will adjust the ticket description too.

Thank you Yana, PR with the version change for camunda-run is merged to the respective 7.20 branch.

Closing the ticket.

[yanavasileva]

7.20 ee run still uses Spring boot 3.1 instead 3.2:
https://github.com/camunda/camunda-bpm-platform-ee-maintenance/blob/7.20/distro/run/pom.xml#L19

[Alexeego]

Hi there!
I see that the ticket is already closed, does it mean that it's already available for downloading from Maven central repository?
Or maybe u could help me and describe a way to get a fixed version 7.20.3?

BR, Alyaksey

[psavidis]

Hi there! I see that the ticket is already closed, does it mean that it's already available for downloading from Maven central repository? Or maybe u could help me and describe a way to get a fixed version 7.20.3?

BR, Alyaksey

Hello Alyaksey,

The feature will be available in 7.20.3, currently scheduled to be released at the end of January.
Hopefully that answers your question.

Kind Regards,
Petros

[Alexeego]

Hello Petros,

If I got you right, the feature already should be available at Maven central repository (7.20.3)(https://mvnrepository.com/artifact/org.camunda.bpm.springboot/camunda-bpm-spring-boot-starter), is it right?
I just couldn't find it, so I really appreciate any help you can provide.

BR, Alyaksey

[psavidis]

Hello Petros,

If I got you right, the feature already should be available at Maven central repository (7.20.3)(https://mvnrepository.com/artifact/org.camunda.bpm.springboot/camunda-bpm-spring-boot-starter), is it right? I just couldn't find it, so I really appreciate any help you can provide.

BR, Alyaksey

Hello @Alexeego ,

The 7.20.3 patch release is available for our enterprise customers only. The community members can still access the feature in the upcoming 7.21.0-alpha3 release, currently scheduled to be released on 13 Feb 2024 and available in maven central.

Best,
Petros