Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Fix favorite card e2e test #83

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Conversation

cmoinier
Copy link
Contributor

@cmoinier cmoinier commented Jun 6, 2024

This PR attempts to fix the recurring failing tests concerning the favorite cards in search.
It improves the login function by reusing the latest version of the same feature in gn-ui. It also improves the clicking function on the favorite button and removes the cy.wait on the following request, not needed anymore since it was the login that was failing.

@cmoinier cmoinier force-pushed the improve-failing-e2e-tests branch 2 times, most recently from 6211901 to 103cb9d Compare June 7, 2024 10:15
@cmoinier cmoinier force-pushed the improve-failing-e2e-tests branch from 2ad2d3c to 85856b0 Compare June 7, 2024 11:25
@cmoinier cmoinier changed the title feat: try CI run [Fix]: Fix favorite card e2e test Jun 7, 2024
@cmoinier cmoinier requested review from tkohr and Angi-Kinas June 7, 2024 11:40
Copy link
Member

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cmoinier for having reworked this! Seems to have passed on the firts CI run 🤞

apps/datahub-e2e/src/e2e/search.cy.ts Outdated Show resolved Hide resolved
@cmoinier cmoinier merged commit 0bb58c5 into main Jun 7, 2024
7 checks passed
@cmoinier cmoinier deleted the improve-failing-e2e-tests branch June 7, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants