[Dataset page] Fix displaying filter button label #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using a mel tailwind component instead of gn-ui button (whose css gets overriden by tailwind base button css) it also aligns the layout fot his button with the mel badge layout (as mel buttons are quite big here)
Angi-Kinas
approved these changes
May 2, 2024
There was a problem hiding this comment.
Thanks @tkohr LGTM 👍
I checked it locally and it looks fine :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes displaying the button label using a mel tailwind component instead of gn-ui button (whose css somehow gets overriden by tailwind base button css). It also aligns the layout for this button with the mel badge layout (as mel buttons are quite big here).
Also moves the google fonts to
resources/assetsthat already provides shared assets for the apps.