Set up e2e tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkohr
force-pushed
the
e2e
branch
4 times, most recently
from
f6be3f2 to
d244200
Compare
Angi-Kinas
reviewed
Jan 16, 2024
There was a problem hiding this comment.
Thanks for setting up the e2e tests @tkohr and improving the README.
I cannot judge the yaml files, maybe someone else wants to have a look here?
The rest looks good to me 👍
fgravin
reviewed
Jan 17, 2024
to have a unique name when using with gn-ui in CI
|
I've rebased the PR, recovered the deleted |
f-necas
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to enable running e2e tests locally and within the CI using the
support-servicesGN backend from gn-ui.Formatting and linting are also added to the CI workflow, and the default nx-cloud workflow is removed.