Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset page] Information block #19

Merged
merged 9 commits into from
Feb 26, 2024
Merged

Conversation

cmoinier
Copy link
Contributor

@cmoinier cmoinier commented Feb 20, 2024

This PR adds the information block elements to the dataset page.

What's included

  • Information items (update date, categories, territories, licences, producer)
  • Keywords filtering logic
  • Social medias share buttons & linking logic
  • e2e

What is not included

  • Territoires : these two buttons are hard coded and are waiting for this field to be harvested later on.
  • Social medias modal : see note in figma. it was decided that implementing a modal to write a message and post it on the user's social media was out of the scope of this PR.

Screenshot

image

@cmoinier cmoinier force-pushed the dataset-information-block branch from 311d341 to 7e25a44 Compare February 20, 2024 10:28
Copy link
Contributor

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmoinier for adding the information block! It looks great already! 🚀
I have some comments, but mainly I noticed some small things in the design.

  • For the keywords in the categories I think the row-gap should be a bit bigger (maybe gap-y-2) and then I think the same can be applied to the territory
  • I am not sure about the design for the license and producer, there are two versions. One without underline and one with (but for me this looks a bit like a link), also I think in one design the value is on the next line
  • the value of the producer is not on the same (baseline) as the key

Let me know if something is not clear or if you need help.

"mel.dataset.download": "Télécharger",
"mel.dataset.favorite": "Favoris",
"mel.dataset.informations": "Informations",
"mel.dataset.less": "Reduire",
"mel.dataset.licenses": "Licence(s) :",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "(s)" needed? I did not see it in the design.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, if we have plural, we could also use translateParams, to display either singular or plural. Not sure if all licenses should be listed here, or just the first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure either, and they can be pretty long strings. I'm going to ask Christophe about it.

Copy link
Member

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice component @cmoinier ! I've added a couple more ideas inline.

@cmoinier cmoinier force-pushed the dataset-information-block branch from b67ca84 to f65bb72 Compare February 22, 2024 13:45
@cmoinier
Copy link
Contributor Author

cmoinier commented Feb 22, 2024

Thanks @Angi-Kinas and @tkohr for the reviews 🙂

The changes addressed with the last commits are :

  • Moved dataset-information to the header template.
  • Displayed only one license (in discussion with Christophe, might change).
  • Increased the row gap for the keywords and territoires.
  • Removed the underline, added weight and put the licenses and producer infos on the same line as their titles.
  • Added a TODO for the territoires information
  • Added tailwind components for the mel-badge-button (primary and secondary)
  • Added a new tailwind component for the social media buttons

Copy link
Member

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks, for all the rework @cmoinier!

Once the fixed width is removed from the component and the last adaptions are made, as discussed everything LGTM 🙂

@cmoinier cmoinier force-pushed the dataset-information-block branch from 76a2275 to b4b19a3 Compare February 23, 2024 09:46
@cmoinier cmoinier force-pushed the dataset-information-block branch from b4b19a3 to 1b9601d Compare February 23, 2024 09:46
@cmoinier cmoinier merged commit 7dad1cc into main Feb 26, 2024
7 checks passed
@cmoinier cmoinier deleted the dataset-information-block branch February 26, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants