feat(footer): open icon links in new tab

camptocamp · May 7, 2024 · 81d75ef · 81d75ef
1 parent ef427ee
commit 81d75ef
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/apps/home-e2e/src/e2e/home.cy.ts b/apps/home-e2e/src/e2e/home.cy.ts
@@ -85,7 +85,7 @@ describe('home', () => {
       cy.get('@url').should('include', 'twitter')
       cy.get('@url').should('include', 'MetropoleLille')
     })
-    it('should display the partners icons', () => {
+    it('should display the partners icons as links', () => {
       cy.get('@footer')
         .children('footer')
         .first()
@@ -95,6 +95,14 @@ describe('home', () => {
         .eq(1)
         .children('a')
         .should('have.length', 2)
+        .each((el, index) => {
+          const urls = [
+            'https://next-generation-eu.europa.eu/index_fr',
+            'https://www.economie.gouv.fr/plan-de-relance',
+          ]
+          cy.wrap(el).should('have.attr', 'href', urls[index])
+          cy.wrap(el).should('have.attr', 'target', '_blank')
+        })
     })
     it('should have a button to the newsletter subscription', () => {
       cy.get('@footer')

diff --git a/libs/mel/src/lib/footer/mel-datahub-footer.component.html b/libs/mel/src/lib/footer/mel-datahub-footer.component.html
@@ -129,14 +129,14 @@
       </ul>
     </div>
     <div class="flex flex-row items-center flex-wrap">
-      <a href="https://next-generation-eu.europa.eu/index_fr">
+      <a href="https://next-generation-eu.europa.eu/index_fr" target="_blank">
         <img
           class="h-20 mr-8"
           src="{{ iconsUrl }}finance_ue.png"
           [alt]="'mel.common.footer.logo.financeUE' | translate"
         />
       </a>
-      <a href="https://www.economie.gouv.fr/plan-de-relance">
+      <a href="https://www.economie.gouv.fr/plan-de-relance" target="_blank">
         <img
           class="h-24"
           src="{{ iconsUrl }}france_relance.png"