DO NOT MERGE ! - Extend web components GSGMF 1650 #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: GSGMF-1650
See also (updated doc) camptocamp/c2cgeoportal#8911
See commit message to understand the history of changes.
I was able to:
querySelector('...').shadowRoot.appendChild
. It work on multiple nested level of Shadow DOM as our component are in anopen
mode. Should also work with a CSSStyleSheet)Well, I had no real problem to do the changes.
Maybe it would be great to split long
render
method to multiple small methods.(As it should be already the case for other methods and especially long constructor (not modifiable))
Result of my changes: