Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support layer short names and WMSUseLayerIDs #5292

Merged
merged 2 commits into from
Sep 16, 2019
Merged

Support layer short names and WMSUseLayerIDs #5292

merged 2 commits into from
Sep 16, 2019

Conversation

arnaud-morvan
Copy link
Member

@arnaud-morvan arnaud-morvan commented Sep 11, 2019 •
edited
Loading

  • Support layer short names and WMSUseLayerIDs
  • Support roles == "ROOT" in get_area

@arnaud-morvan arnaud-morvan force-pushed the qgis-support-shortnames-layerids branch from df3e032 to f27f511 Compare September 13, 2019 09:56
@camptocamp camptocamp deleted a comment Sep 13, 2019
@arnaud-morvan arnaud-morvan force-pushed the qgis-support-shortnames-layerids branch from f27f511 to c8e2b10 Compare September 13, 2019 13:11
@arnaud-morvan arnaud-morvan marked this pull request as ready for review September 13, 2019 13:13
@arnaud-morvan
Copy link
Member Author

@sbrunner : I've added some tests and fixed a bug with root in get_area.
Could you have a look.

@camptocamp camptocamp deleted a comment Sep 13, 2019
@arnaud-morvan arnaud-morvan force-pushed the qgis-support-shortnames-layerids branch from c8e2b10 to 3a58fa1 Compare September 13, 2019 14:05
@camptocamp camptocamp deleted a comment Sep 13, 2019
sbrunner
sbrunner approved these changes Sep 13, 2019
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be on 2.4

@arnaud-morvan arnaud-morvan force-pushed the qgis-support-shortnames-layerids branch from 3a58fa1 to f6f4ef7 Compare September 16, 2019 07:36
@arnaud-morvan arnaud-morvan changed the base branch from master to 2.4 September 16, 2019 07:37
@arnaud-morvan
Copy link
Member Author

After rebase on 2.4, I made some tests with stpierre_geomapfish, no problem detected, so let's merge into 2.4.

@arnaud-morvan arnaud-morvan merged commit ee12fcd into 2.4 Sep 16, 2019
@arnaud-morvan arnaud-morvan deleted the qgis-support-shortnames-layerids branch September 16, 2019 08:47
@sbrunner sbrunner added this to the 2.4.2 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@arnaud-morvan @sbrunner