Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix phantom js checks #5159

Merged
merged 6 commits into from
Jul 18, 2019
Merged

Fix phantom js checks #5159

merged 6 commits into from
Jul 18, 2019

Conversation

sbrunner
Copy link
Member

The working part of #5144

@sbrunner sbrunner added this to the 2.5 milestone Jul 17, 2019
@sbrunner sbrunner requested a review from fredj July 17, 2019 15:12
@sbrunner sbrunner marked this pull request as ready for review July 18, 2019 06:54
@sbrunner
Copy link
Member Author

Already reviewed in #5144, merging :-)

@sbrunner sbrunner merged commit 42d43ef into master Jul 18, 2019
@sbrunner sbrunner deleted the phantomjs4 branch July 18, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj Awaiting requested review from fredj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
1 participant
@sbrunner