Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent using unsecure secret #5076

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Prevent using unsecure secret #5076

merged 1 commit into from
Jun 27, 2019

Conversation

gberaudo
Copy link
Member

No description provided.

@gberaudo gberaudo requested a review from sbrunner June 25, 2019 11:37
@gberaudo gberaudo force-pushed the prevent_using_unsecure_auth_secret branch from 05c6e13 to 5b4ae74 Compare June 25, 2019 12:43
@camptocamp camptocamp deleted a comment Jun 25, 2019
@camptocamp camptocamp deleted a comment Jun 25, 2019
@gberaudo gberaudo force-pushed the prevent_using_unsecure_auth_secret branch from cd028ee to 4e564f5 Compare June 25, 2019 13:26
@gberaudo gberaudo changed the base branch from 2.3 to master June 25, 2019 13:27
@camptocamp camptocamp deleted a comment Jun 25, 2019
sbrunner
sbrunner approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@gberaudo gberaudo force-pushed the prevent_using_unsecure_auth_secret branch from 4e564f5 to a413478 Compare June 27, 2019 11:02
@camptocamp camptocamp deleted a comment Jun 27, 2019
@gberaudo gberaudo merged commit 9e724eb into master Jun 27, 2019
@gberaudo gberaudo deleted the prevent_using_unsecure_auth_secret branch June 27, 2019 12:21
@sbrunner sbrunner added this to the 2.5 milestone Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.
2 participants
@gberaudo @sbrunner