Fix #2582 - Backport ability to log user and date to 1.6 #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Nov 3, 2016
| return get_class( | ||
| str(layer.geo_table), | ||
| exclude_properties=layer.exclude_properties | ||
| exclude_properties=','.join(exclude) |
There was a problem hiding this comment.
please use double quotes: exclude_properties=",".join(exclude) (travis error)
|
I'm not sure what coveralls test. Which tests (6?) are failing? |
|
@sbrunner can we ignore the coveralls test? I yes, I think it's good to merge. |
|
I'll wait for @sbrunner feedback before merging. |
|
@juliensam can you fix the author on the two first commits? this 4b6199b should also be backported :-) Finally can you merge all the commits in one commit? |
juliensam
force-pushed
the
log_last_update_1_6
branch
2 times, most recently
from
9299212 to
3fe507f
Compare
|
Commit squashed and the layer tests now pass. It seems that Travis is raising a few errors in other parts of the code. I suggest to fix those in another pull request. In short, ready to review. |
|
#2640 should fix the Travis failure, can you do rebase? |
juliensam
force-pushed
the
log_last_update_1_6
branch
from
3fe507f to
3f4c153
Compare
|
Ready to review |
|
Thanks :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.