Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook link #515

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Fix notebook link #515

merged 2 commits into from
Dec 26, 2024

Conversation

vinayak-mehta
Copy link
Member

No description provided.

@vinayak-mehta vinayak-mehta merged commit 2c366d5 into master Dec 26, 2024
13 checks passed
@vinayak-mehta vinayak-mehta deleted the vinayak/2024-12-26-fix-notebook-linj branch December 26, 2024 22:33
@bosd
Copy link
Collaborator

bosd commented Dec 27, 2024

fyi, notebook link is still broken

@vinayak-mehta
Copy link
Member Author

let me check

@vinayak-mehta
Copy link
Member Author

both links open for me from the github readme and readthedocs, are there other notebook links somewhere in the docs?

@bosd
Copy link
Collaborator

bosd commented Dec 29, 2024

fix in #517

The "code fix" in this commit is not working for me.
Before: (quickly taken from other repo.)
image

here:
image

@vinayak-mehta
Copy link
Member Author

Let me check

@bosd
Copy link
Collaborator

bosd commented Dec 29, 2024

There is more, these ones need upadting as well.
https://github.com/camelot-dev/camelot/blob/master/docs/user/how-it-works.rst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vinayak-mehta @bosd