Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed library discovery on Windows #32

Merged
merged 1 commit into from
Jul 24, 2019
Merged

Fixed library discovery on Windows #32

merged 1 commit into from
Jul 24, 2019

Conversation

KOLANICH
Copy link
Contributor

@KOLANICH KOLANICH commented Jul 16, 2019

When gsdll.dll is not found in the usual place in the Windows registry, ctypes.util.find_library() is used as a fallback to search %PATH%, before raising RuntimeError.

@codecov-io
Copy link

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   87.69%   87.69%           
=======================================
  Files          13       13           
  Lines        1511     1511           
  Branches      349      349           
=======================================
  Hits         1325     1325           
  Misses        129      129           
  Partials       57       57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7b94b3...9e356b1. Read the comment docs.

@KOLANICH
Copy link
Contributor Author

@vinayak-mehta

@vinayak-mehta
Copy link
Member

vinayak-mehta commented Jul 22, 2019

Please give me some time to check this out. 👍

Copy link
Contributor

@dimitern dimitern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It would've been nice to be able to run CI tests on Windows, so there can be a unit test for this, but until we do, I think we should merge your fix.

@KOLANICH
Copy link
Contributor Author

KOLANICH commented Jul 23, 2019

It would've been nice to be able to run CI tests on Windows

I wonder if Wine is a suitable substitute....

@dimitern dimitern merged commit 6d33c7f into camelot-dev:master Jul 24, 2019
@KOLANICH KOLANICH deleted the ghostscript_discovery_win branch July 24, 2019 12:26
@vinayak-mehta
Copy link
Member

@KOLANICH Thanks for the PR! @dimitern Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants