Add pdftopng and use ghostscript as fallback #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay most tests pass! 🎉 The ones that failed have image coordinates hardcoded, they will have to be changed. |
|
@vinayak-mehta Let me know if further testing is needed on this PR or any task the needs to be done to move this forward. Thanks |
vinayak-mehta
force-pushed
the
add-pdftopng
branch
from
3ff5b30 to
286b2d6
Compare
|
Just need to add tests now. |
|
It's just failing on macOS :( |
vinayak-mehta
changed the title
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised this PR just to run tests. This change would have to be handled in a backwards compatible way by adding support for multiple image conversion backends which the user could specify (
ghostscript,mupdf, etc.), and settingpdftopngas the default one.