Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 11.5 support #33

Merged
merged 4 commits into from
Jan 7, 2024
Merged

add 11.5 support #33

merged 4 commits into from
Jan 7, 2024

Conversation

gingerbeardman
Copy link
Contributor

No description provided.

@camchenry
Copy link
Owner

This looks good, but there was an error with the array lengths. I updated this code to used inferred array lengths instead, as that seems slightly more maintainable: gingerbeardman#1.

[PR camchenry#33] Use inferred static array of love versions
@gingerbeardman
Copy link
Contributor Author

gingerbeardman commented Jan 2, 2024

Thanks! @camchenry merged in my fork

I didn't compile the code (lack of time, put off by other issues saying there were compile problems so simply didn't try) so was flying blind and missed some things. :)

@camchenry
Copy link
Owner

@gingerbeardman looks like CI is broken, which is unfortunate. I'll need to look into fixing that before merging, sorry.

@camchenry
Copy link
Owner

Looks like this is working now, thank you again for the contribution.

@camchenry camchenry merged commit d090ab6 into camchenry:main Jan 7, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants