Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug in the default ignore list and some compiler warnings #27

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

kungfoo
Copy link
Contributor

@kungfoo kungfoo commented Sep 22, 2021

This pattern causes the default ignore_list to ignore not only the release folder, but also assets and files named foo-released.ogg and quest-release-me.lua.

This will cause assets or files named 'something-released.foo'
to be filtered from the build.
Copy link
Owner

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @kungfoo! I greatly appreciate it.

Overall, these changes look good. I'd like to get your thoughts on the comments that I left before merging in these changes though.

Thanks!

Boon.toml Outdated Show resolved Hide resolved
src/download.rs Outdated Show resolved Hide resolved
@camchenry camchenry merged commit 12944ba into camchenry:main Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants