1851 add oura ring api key #1461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kok-foong
reviewed
Feb 3, 2025
Comment on lines
+98
to
+103
| private TokenIntrospectionResponse getTokenIntrospectResponse(HttpServletRequest httpRequest) { | ||
| AuthorizationRequest request = new AuthorizationRequest(); | ||
| AuthorizationResponse response = authzClient.authorization(httpRequest.getHeader("Authorization").replace("Bearer ", "")).authorize(request); | ||
|
|
||
| } else if (request.getRequestURI().contains("getPhoneIds")) { | ||
| validateInputGetPhoneIds(requestParams); | ||
| JSONArray phoneIds = kgQueryClient.getPhoneIds(requestParams.getString("userId")); | ||
| JSONObject result = new JSONObject(); | ||
| result.put("PhoneIds", phoneIds); | ||
| result.put("Comment", "Phone ids are retrieved."); | ||
| return result; | ||
| TokenIntrospectionResponse tokenIntrospectionResponse = authzClient.protection().introspectRequestingPartyToken(response.getToken()); | ||
| return tokenIntrospectionResponse; |
There was a problem hiding this comment.
what's the purpose of this method? I think the /userinfo endpoint already validates the token?
There was a problem hiding this comment.
This one is to check whether the token has the permission to perform the operations (eg. registerPhone, getPhoneIds, registerOuraRing), although we now allow all users to perform these three operations.
There was a problem hiding this comment.
This is fine, just wondering if there is a way to only contact KeyCloak once instead of twice
kok-foong
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add oura ring api key to twa account mapping