Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #33 #34

Merged
merged 1 commit into from
Mar 25, 2023
Merged

Fix issue #33 #34

merged 1 commit into from
Mar 25, 2023

Conversation

Alylaxy
Copy link
Contributor

@Alylaxy Alylaxy commented Mar 24, 2023

I hope that I understood this issue and the docs correctly.

Anyways, here's my attempt! Please, tell me if I got something wrong.

Copy link
Collaborator

@tavareshugo tavareshugo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks for your contribution!
I will also add you to the acknowledgements.

@tavareshugo tavareshugo merged commit 4424998 into cambiotraining:main Mar 25, 2023
@Alylaxy
Copy link
Contributor Author

Alylaxy commented Mar 27, 2023

Thank you, but there's no need. I'm just happy to help! Besides, appearing as a contributor in the repository is enough for me. I'll keep looking into the issues and see if I can help with something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants