Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #764

Merged
merged 4 commits into from
Feb 20, 2024
Merged

chore: migrate AWS SDK for JavaScript v2 APIs to v3 #764

merged 4 commits into from
Feb 20, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 14, 2023

Summary

This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx [email protected] -t v2-to-v3 example/**/*.ts

Reference(s)

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

Checklist

Copy link

changeset-bot bot commented Nov 14, 2023

⚠️ No Changeset found

Latest commit: a79291a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trivikr trivikr marked this pull request as ready for review November 15, 2023 00:00
@trivikr
Copy link
Contributor Author

trivikr commented Feb 19, 2024

I've rebase changes from develop branch since the last three months, and updated package lockfile.
Is there anything else needed for review and merge of this change?

cc @ishikawa-pro @nonoakij

Copy link
Contributor

@nonoakij nonoakij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply.
Thanks for this update.

@nonoakij nonoakij merged commit f4c3e29 into cam-inc:develop Feb 20, 2024
@trivikr trivikr deleted the aws-sdk-js-codemod branch February 20, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants