-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay] softmax, max_pool2d, conv2d, fix 4D memory connections (WIP) #289
Conversation
The TODOs left for |
@rachitnigam I've removed the unnecessary additions to the primitives library and marked softmax as unimplemented for now. This CL is already pretty large, so I can finish the rest in a follow-up CL. |
Are there any tests you want to enable by default in the top-level |
At this time, no. Perhaps after the |
Overview
nn.max_pool2d
implementation with test.nn.conv2d
implementation with test.runt
test, since I missed this bug in an earlier PR.Relay function call
->Dahlia function
->FuTIL lowering
is done in a single filedahlia_lowering.py
now.VGG Net
from Relay IR to FuTIL, i.e.python3 example.py vgg_net
. This is by no means fast; loweringMLP Net
is faster given the smaller number of instructions. I've also verified the FuTIL output lowers to Verilog in both cases.TODOs Left
nn.softmax
to avoid integer underflow for fixed point. Currently, this includes astd_exp
operator, however, this operator rounds to the nearest integer because of the following:Ideally, we'd like that not to occur. I mention this in #299 , though I'm not sure I'll have time to work on this more before Tuesday. I believe this will be easy to do once we can support generalized functions with
invoke
.