Small tweaks to fud2 #1879
Merged
Small tweaks to fud2 #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was inconsistent about whether to use snake_case or kebab-case; this standardizes us on the latter (and brings a few other names in line with each other).
The old name, `data`, was ridiculously vague and I don't know why I ever thought it was a good idea. `rsrc` is slightly better. This also changes the config option name; if you were using fud2 already, you will need to change this.
|
Merging this because I'm doing a little reorg! Hopefully there wasn't anything else that needed to be done |
|
Great; thanks!! |
rachitnigam
pushed a commit
that referenced
this pull request
Feb 16, 2024
* More consistent Ninja variable names I was inconsistent about whether to use snake_case or kebab-case; this standardizes us on the latter (and brings a few other names in line with each other). * Rename resources directory The old name, `data`, was ridiculously vague and I don't know why I ever thought it was a good idea. `rsrc` is slightly better. This also changes the config option name; if you were using fud2 already, you will need to change this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two pieces of technical-debt backlog that I wanted to clear after merging #1877. Neither is very consequential! I just couldn't live with them floating out there, unfixed:
rsrc, notdata, which was annoyingly vague.