Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Single session #1797

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Implemented Single session #1797

merged 5 commits into from
Dec 5, 2023

Conversation

kadenlei
Copy link
Contributor

Implemented single-session mode for the debugger by creating a new CiderDebugAdapterDescriptorFactoryExecutable and using that factory when the configuration in the settings is set to "Single-Session". Multi-session should work as it did before, and can be run by changing the session type to "Multi-Session".

Copy link
Collaborator

@EclecticGriffin EclecticGriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Really glad we could get this working smoothly. Just take care of the notes and merge when things go green

.vscode/launch.json Outdated Show resolved Hide resolved
cider-dap/calyxDebug/extension.ts Outdated Show resolved Hide resolved
cider-dap/calyxDebug/extension.ts Outdated Show resolved Hide resolved
cider-dap/src/main.rs Outdated Show resolved Hide resolved
@EclecticGriffin
Copy link
Collaborator

@kadenlei lmk if you want a hand cleaning up the merge conflicts

@kadenlei kadenlei merged commit dfd45c6 into master Dec 5, 2023
5 checks passed
@kadenlei kadenlei deleted the single-session branch December 5, 2023 20:24
rachitnigam pushed a commit that referenced this pull request Feb 16, 2024
* Still working

* Implemented single-session and configurations for session type

* Finalizaing single-session

* Resolved comments

* Got rid of dead code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants