Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted extension.js to typescript #1772

Merged
merged 6 commits into from
Nov 15, 2023
Merged

Converted extension.js to typescript #1772

merged 6 commits into from
Nov 15, 2023

Conversation

kadenlei
Copy link
Contributor

The new extension.ts file compiles to extension.js which is within the built directory of calyxDebug. Additionally made the cider binary path and port number configurable by changing the settings of the extension within VSCode.

Copy link
Collaborator

@EclecticGriffin EclecticGriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ideally the extension.js file wouldn't be committed since we'd like that to compile automatically but good job on the configuration stuff!

@EclecticGriffin
Copy link
Collaborator

Merge when ready

@kadenlei kadenlei merged commit 187abf2 into master Nov 15, 2023
5 checks passed
@kadenlei kadenlei deleted the extension-typescript branch November 15, 2023 02:11
rachitnigam pushed a commit that referenced this pull request Feb 16, 2024
* Started working on ts conversion

* Worked on ts file

* Deleted accidentally committed files

* Converted to ts and made ports and path configurable

* Edited README

* deleted extension.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants