Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change remove-comb-groups to only simplify if-with and while-with #1422

Merged
merged 7 commits into from
Apr 27, 2023

Conversation

rachitnigam
Copy link
Contributor

Changes the pass to only transform the if-with and while-with constructs into if and while respectively. Importantly, it leaves invoke-with alone and makes it compile-invoke's responsibility to handle them. This addresses the long open issue of group2invoke -> compile-invoke making the latency of everything worse since group2invoke introduces invoke-with statements while remove-comb-groups turns them into seq { gr; invoke }

Closes #911.

@rachitnigam rachitnigam merged commit fb15c5e into master Apr 27, 2023
@rachitnigam rachitnigam deleted the simplify-with-control branch April 27, 2023 14:48
@sampsyo
Copy link
Contributor

sampsyo commented Apr 27, 2023

Very very awesome! This is some good thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove-comb-groups should be optional
2 participants