Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding cmds & tests for Container app certs & domains #107
Adding cmds & tests for Container app certs & domains #107
Changes from 84 commits
1de51ee
7735595
2e1be89
5fcd785
a1929c8
df5cc99
0dedf19
1474d69
5afc2b1
77dcaa0
5cc0aa8
1f1b31a
7f70e2f
fa539a8
f935df8
7da2e9a
fcc3d87
cb6820e
f6efbd2
4e805bf
7f7f1fe
3d794b3
e87accc
552850f
b86d217
31002f8
c292ac9
b9fce25
077bf20
c100f1f
44faaf7
197913a
595cdf5
272146b
988d901
e935bf2
50617e1
757dcf4
cbeac7a
44aa7ff
a016f35
c59d257
bd2cc8b
2b58d27
668b7d9
25843f1
612d1a5
900e7b6
6710636
50e0754
d53550b
66878c7
37627de
5f5308e
7b0bd7d
c534455
3e576de
724249a
a1ce4dd
4fc7267
a8a6ac1
5570ad9
2ccbce0
34aabca
6b3468a
53ddc45
711bbd4
65cb30c
13f217a
e86e089
8960d75
a8737a0
1165dc9
a4590f4
1b8c7e0
40ca5b9
4e7c369
0b15002
34eab57
0a32abd
af7f143
7c6b49e
61db16e
75d1323
2e6f013
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage of this ACA should be consistent across all help - since it is the name of the service. Looks like other commands call it 'container app' so please check & update all accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For environment level operations, other commands like
dapr-component
andstorage
are using "Container Apps environment".Keep it as is for certificate commands. Hostname commands are using "container app".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't list command take a certificate name or ID as an input as well. Can you add more sample help commands here on usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We allow user to provide their own cert name as well right? please add sample commands as examples here for usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given this takes thumbprint as input as well - add those examples as well for usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the certificate object Model not have other properties? like thumbprint, name etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panchagnula This model is only for the add cert api request. It is consistent with the api requirement.
I'll change the model name to make it more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For List - this can be the full cerificate_resource_id as well right? Please update help to clarify this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the CLI linter has a rule
no_ids_for_list_commands
that prevents using --ids with list commandsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see got it. this is for --ids. Can we validate the command itself behaves correctly / works when a user gives the full certificate resource ID & not just the name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@panchagnula I'll add a test for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason we set id_part=None for certificates? The user should be able to use the resourceID of the certificate as well right?