Pr/fix extension for plain text json html content type #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just confirming this works for me, thanks for the PR. Hope it gets merged. |
|
+1 please merge this |
|
Doesn't look like this is being merged, but I fixed the same issue in my fork: https://github.com/nikrolls/json-formatter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, with the recent death of JsonView (one of my favorite Chrome Extensions) I decided to take a look at yours, which to my disappointment didn't work. Later it did, and digging into it, looks like it wasn't handling the case where there was a plain text JSON response with a ContentType of text/html.
Made a quick fix, check it out!