Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repack): Add namespace to build.gradle for react-native 0.73+ compat #379

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

RafikiTiki
Copy link
Member

Summary

This is a change that'll be required starting from React Native 0.73.x. More context can be found here: react-native-community/discussions-and-proposals#671

Test plan

  • Build & run the app using updated Repack package in RN 0.71.x in both Debug and Release modes
  • Build & run the app using updated Repack package in RN 0.67.x in both Debug and Release modes

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2023

🦋 Changeset detected

Latest commit: 55694fb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@callstack/repack Patch
testerapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RafikiTiki RafikiTiki merged commit 229c4f8 into main Jun 19, 2023
@RafikiTiki RafikiTiki deleted the chore/repack/update-android-package-namespace branch June 19, 2023 11:29
RafikiTiki added a commit that referenced this pull request Jun 19, 2023
RafikiTiki added a commit that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants