Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend default test match #523

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Aug 28, 2024

Summary

Before:

  • files ending in *.perf-test.(js|jsx|ts|tsx)

After:

  • files ending in *.perf-test.(js|jsx|ts|tsx)
  • files ending in *.perf.(js|jsx|ts|tsx)
  • files in __perf__ folder

Test plan

Manual tests

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 0e4e7cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/reassure-cli Minor
reassure Minor
@callstack/reassure-compare Minor
@callstack/reassure-danger Minor
@callstack/reassure-logger Minor
@callstack/reassure-measure Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Performance Comparison Report

  • Current: HEAD (f3515c1) - 2024-08-28 12:35:08Z
  • Baseline: main (ce30981) - 2024-08-28 12:34:14Z

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 110.7 ms → 108.8 ms (-1.9 ms, -1.7%) 7 → 7
fib 30 function 38.5 ms → 39.7 ms (+1.2 ms, +3.0%) 1 → 1
fib 31 function 62.3 ms → 63.9 ms (+1.6 ms, +2.5%) 1 → 1
fib 32 function 101.2 ms → 101.9 ms (+0.7 ms, +0.7%) 1 → 1
InitialRenders 1 render 1.1 ms → 1.1 ms 2 → 2
InitialRenders 3 render 1.0 ms → 1.4 ms (+0.4 ms, +40.0%) 🔴 4 → 4
ManyRenderIssues render 1.8 ms → 1.6 ms (-0.2 ms, -11.1%) 5 → 5
Other Component 10 render 71.7 ms → 70.9 ms (-0.8 ms, -1.1%) 4 → 4
Other Component 10 legacy scenario render 69.4 ms → 69.4 ms 4 → 4
Other Component 20 render 66.7 ms → 68.3 ms (+1.7 ms, +2.6%) 4 → 4
RedundantUpdates render 1.3 ms → 0.8 ms (-0.5 ms, -38.5%) 🟢 2 → 2
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 110.7 ms
Stdev: 8.1 ms (7.4%)
Runs: 109 114 113 120 117 106 98 121 111 98
Warmup runs: 115

Current
Mean: 108.8 ms
Stdev: 7.7 ms (7.1%)
Runs: 103 116 105 110 104 113 100 125 110 102
Warmup runs: 121
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
Render issues:
- Initial updates: 1
fib 30 function Baseline
Mean: 38.5 ms
Stdev: 0.1 ms (0.1%)
Runs: 38.5 38.5 38.5 38.5 38.7 38.5 38.5 38.5 38.5 38.5
Warmup runs: 36.1

Current
Mean: 39.7 ms
Stdev: 1.6 ms (4.1%)
Runs: 38.8 38.8 38.8 41.4 38.6 39.6 43.7 39.0 39.1 39.0
Warmup runs: 36.1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 31 function Baseline
Mean: 62.3 ms
Stdev: 0.2 ms (0.3%)
Runs: 62.2 62.2 62.0 62.4 62.3 62.3 62.6 62.5 62.2 62.3
Warmup runs: 62.2

Current
Mean: 63.9 ms
Stdev: 1.9 ms (2.9%)
Runs: 62.2 62.8 68.6 63.1 63.0 64.8 63.0 63.0 63.1 65.0
Warmup runs: 62.1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 32 function Baseline
Mean: 101.2 ms
Stdev: 2.3 ms (2.3%)
Runs: 101.6 102.0 102.0 102.2 102.0 102.0 102.1 101.9 101.9 94.7
Warmup runs: 93.2

Current
Mean: 101.9 ms
Stdev: 0.1 ms (0.1%)
Runs: 101.9 101.9 101.8 102.0 101.9 102.0 101.8 101.9 102.0 102.0
Warmup runs: 101.7
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
InitialRenders 1 render Baseline
Mean: 1.1 ms
Stdev: 0.7 ms (67.1%)
Runs: 0 2 1 0 1 1 2 1 1 2
Warmup runs: 1

Current
Mean: 1.1 ms
Stdev: 0.6 ms (51.6%)
Runs: 1 2 1 2 1 1 1 1 1 0
Warmup runs: 1
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Initial updates: 1
InitialRenders 3 render Baseline
Mean: 1.0 ms
Stdev: 0.5 ms (47.1%)
Runs: 1 1 2 1 1 1 1 1 1 0
Warmup runs: 2

Current
Mean: 1.4 ms
Stdev: 0.5 ms (36.9%)
Runs: 2 1 1 2 1 2 1 1 1 2
Warmup runs: 1
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 3
ManyRenderIssues render Baseline
Mean: 1.8 ms
Stdev: 0.6 ms (35.1%)
Runs: 2 2 2 2 2 3 1 1 1 2
Warmup runs: 1

Current
Mean: 1.6 ms
Stdev: 0.7 ms (43.7%)
Runs: 1 2 2 2 3 1 1 1 2 1
Warmup runs: 1
Baseline
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)

Current
Mean: 5
Stdev: 0 (0.0%)
Runs: 5 5 5 5 5 5 5 5 5 5
Render issues:
- Initial updates: 2
- Redundant updates: 2 (3, 4)
Other Component 10 render Baseline
Mean: 71.7 ms
Stdev: 3.2 ms (4.5%)
Runs: 68 72 75 72 71 77 73 70 66 73
Warmup runs: 286

Current
Mean: 70.9 ms
Stdev: 5.3 ms (7.5%)
Runs: 69 73 68 66 69 80 67 76 64 77
Warmup runs: 303
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 10 legacy scenario render Baseline
Mean: 69.4 ms
Stdev: 6.0 ms (8.6%)
Runs: 67 76 73 64 64 70 67 64 67 82
Warmup runs: 70

Current
Mean: 69.4 ms
Stdev: 3.9 ms (5.7%)
Runs: 70 70 72 65 62 67 72 71 69 76
Warmup runs: 72
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
Other Component 20 render Baseline
Mean: 66.7 ms
Stdev: 2.9 ms (4.4%)
Runs: 64 67 67 61 65 67 66 66 69 67 71 65 68 65 63 73 67 66 64 72
Warmup runs: 69

Current
Mean: 68.3 ms
Stdev: 6.5 ms (9.4%)
Runs: 66 68 69 56 60 69 63 68 67 75 74 71 70 67 84 62 80 66 64 68
Warmup runs: 67
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Render issues:
- Initial updates: 1
RedundantUpdates render Baseline
Mean: 1.3 ms
Stdev: 0.5 ms (37.2%)
Runs: 2 1 1 1 2 1 1 1 2 1
Warmup runs: 1

Current
Mean: 0.8 ms
Stdev: 0.6 ms (79.1%)
Runs: 1 0 1 1 2 0 1 1 1 0
Warmup runs: 1
Baseline
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Current
Mean: 2
Stdev: 0 (0.0%)
Runs: 2 2 2 2 2 2 2 2 2 2
Render issues:
- Redundant updates: 1 (1)

Render Count Changes

There are no entries

Render Issues

Name Initial Updates Redundant Updates
Other Component 10 1 🔴 -
Other Component 10 legacy scenario 1 🔴 -
Other Component 20 1 🔴 -
InitialRenders 1 1 🔴 -
InitialRenders 3 3 🔴 -
RedundantUpdates - 1 (1) 🔴
ManyRenderIssues 2 🔴 2 (3, 4) 🔴
Async Component 1 🔴 -

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 0e4e7cc

@mdjastrzebski mdjastrzebski merged commit cd71fa7 into main Aug 28, 2024
2 checks passed
@mdjastrzebski mdjastrzebski deleted the feat/extend-default-test-match branch August 28, 2024 12:45
@mdjastrzebski
Copy link
Member Author

This PR has been released in Reassure v1.2.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant