fix: respect to the "testingLibrary" config option #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found out that the
testingLibrary
option provided in the config object is not respected in thegetTestingLibrary
function. The function returns 'react-native' no matter what we provide in the configuration.Looks like the early return statement accidentally removed or forgotten during the v1 effort.
measureRenderInternals
function relies ongetTestingLibrary
and runs this code forreact-native
. It throws an error withreact
testing library, thus this tiny mistake makesreassure
unusable withreact
testing library. This PR addresses that issue.Test plan
Provide
react
astestingLibrary
config optionIdeally, see if it works with
@testing-library/react
(I don't think there's a setup for that in the repo)Or, check if
getTestingLibrary
andresolveTestingLibrary
functions resolve properly.