Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: make measureFunction a public API #418

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

adhorodyski
Copy link
Contributor

Summary

This PR fixes lack of the measureFunction function in the public API.

Test plan

Put import {measureFunction} from 'reassure'; in your test file.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: beb953a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
reassure Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Performance Comparison Report

  • Current: 77300e6 - 2023-10-13 08:48:42Z
  • Baseline: main (0179205) - 2023-10-13 08:47:23Z

Significant Changes To Duration

Name Type Duration Count
fib 32 function 362.8 ms → 371.5 ms (+8.7 ms, +2.4%) 1 → 1
fib 30 function 138.8 ms → 144.8 ms (+6.1 ms, +4.4%) 1 → 1
Show details
Name Type Duration Count
fib 32 function Baseline
Mean: 362.8 ms
Stdev: 0.7 ms (0.2%)
Runs: 364.3 363.4 363.1 362.9 362.8 362.7 362.7 362.5 362.3 361.4

Current
Mean: 371.5 ms
Stdev: 7.6 ms (2.0%)
Runs: 381.6 381.1 379.3 378.3 370.8 365.2 365.1 364.9 364.8 364.4
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
fib 30 function Baseline
Mean: 138.8 ms
Stdev: 0.4 ms (0.3%)
Runs: 139.3 139.2 139.0 139.0 138.8 138.7 138.6 138.5 138.4 138.2

Current
Mean: 144.8 ms
Stdev: 6.2 ms (4.3%)
Runs: 159.6 150.7 145.9 144.4 144.0 144.0 140.2 140.0 139.9 139.8
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Meaningless Changes To Duration

Show entries
Name Type Duration Count
Async Component render 304.0 ms → 310.5 ms (+6.5 ms, +2.1%) 7 → 7
fib 31 function 223.7 ms → 225.7 ms (+1.9 ms, +0.9%) 1 → 1
Other Component 10 render 190.9 ms → 186.4 ms (-4.5 ms, -2.4%) 4 → 4
Other Component 10 legacy scenario render 185.2 ms → 182.9 ms (-2.3 ms, -1.2%) 4 → 4
Other Component 20 render 191.2 ms → 188.3 ms (-2.8 ms, -1.5%) 4 → 4
Show details
Name Type Duration Count
Async Component render Baseline
Mean: 304.0 ms
Stdev: 9.5 ms (3.1%)
Runs: 313 313 312 312 309 305 302 293 292 289

Current
Mean: 310.5 ms
Stdev: 15.7 ms (5.1%)
Runs: 341 326 322 315 310 307 300 298 293 293
Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
fib 31 function Baseline
Mean: 223.7 ms
Stdev: 0.6 ms (0.3%)
Runs: 225.0 224.3 224.0 223.8 223.7 223.6 223.5 223.3 223.2 222.9

Current
Mean: 225.7 ms
Stdev: 0.4 ms (0.2%)
Runs: 226.3 226.1 226.0 225.7 225.7 225.7 225.7 225.2 225.2 225.1
Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Other Component 10 render Baseline
Mean: 190.9 ms
Stdev: 11.7 ms (6.1%)
Runs: 212 200 200 199 192 187 185 178 178 178

Current
Mean: 186.4 ms
Stdev: 7.4 ms (4.0%)
Runs: 202 192 189 187 187 186 185 183 177 176
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 10 legacy scenario render Baseline
Mean: 185.2 ms
Stdev: 4.9 ms (2.7%)
Runs: 195 191 187 186 186 184 182 181 180 180

Current
Mean: 182.9 ms
Stdev: 5.4 ms (3.0%)
Runs: 193 188 187 185 183 182 180 178 177 176
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 20 render Baseline
Mean: 191.2 ms
Stdev: 8.3 ms (4.3%)
Runs: 210 204 201 200 200 196 193 191 191 190 190 189 187 185 185 184 184 183 181 180

Current
Mean: 188.3 ms
Stdev: 8.7 ms (4.6%)
Runs: 211 202 196 195 193 192 190 189 188 188 187 187 186 186 185 183 182 178 177 172
Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Changes To Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against beb953a

@mdjastrzebski mdjastrzebski merged commit d74f81e into main Oct 13, 2023
@mdjastrzebski mdjastrzebski deleted the hotfix/measure-function-export branch October 13, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants