Added support for passing a custom --testMatch option to Jest

[Xiltyn]

Summary

Resolves: #314

• Added new option to yarn reassure measure and subsequently - yarn reassure commands: --file | -f
• Added validation for the option by checking whether provided file exists
• Fallback to default if file does not exist

Important
Using TEST_RUNNER_ARGS will override this feature as it works by adjusting the defaultArgs string

Test plan

1. Clone repo
2. run yarn
3. run yarn reassure -f "examples/native/src/OtherTest.perf-test.tsx"

Result: Only one test is ran

Demo

reassure-cli-single-file.mov

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6c41d08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Performance Comparison Report

• Current: 3add40e
• Baseline: main (ee8a5d5)

Significant Changes To Render Duration

Name	Render Duration	Render Count
Other Component 10 legacy scenario	150.0 ms → 145.2 ms (-4.8 ms, -3.2%)	4 → 4

Show details

Name	Render Duration	Render Count
Other Component 10 legacy scenario	Baseline Mean: 150.0 ms Stdev: 4.4 ms (2.9%) Runs: 157 157 152 150 150 149 148 148 146 143 Current Mean: 145.2 ms Stdev: 4.1 ms (2.8%) Runs: 151 149 148 147 147 145 143 143 142 137	Baseline Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4 Current Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4

Meaningless Changes To Render Duration

Show entries

Name	Render Duration	Render Count
Async Component	240.7 ms → 241.6 ms (+0.9 ms, ±0.0%)	7 → 7
Other Component 10	151.9 ms → 152.4 ms (+0.5 ms, ±0.0%)	4 → 4
Other Component 20	151.3 ms → 149.1 ms (-2.3 ms, -1.5%)	4 → 4

Show details

Name	Render Duration	Render Count
Async Component	Baseline Mean: 240.7 ms Stdev: 6.1 ms (2.5%) Runs: 249 248 244 244 242 242 238 236 233 231 Current Mean: 241.6 ms Stdev: 9.8 ms (4.1%) Runs: 261 254 245 242 242 238 237 237 231 229	Baseline Mean: 7 Stdev: 0 (0.0%) Runs: 7 7 7 7 7 7 7 7 7 7 Current Mean: 7 Stdev: 0 (0.0%) Runs: 7 7 7 7 7 7 7 7 7 7
Other Component 10	Baseline Mean: 151.9 ms Stdev: 3.9 ms (2.6%) Runs: 158 157 156 153 151 150 150 149 148 147 Current Mean: 152.4 ms Stdev: 3.1 ms (2.1%) Runs: 157 157 154 153 153 152 151 151 148 148	Baseline Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4 Current Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 20	Baseline Mean: 151.3 ms Stdev: 5.2 ms (3.5%) Runs: 162 158 155 155 155 154 153 153 153 153 153 151 150 150 148 148 148 146 141 140 Current Mean: 149.1 ms Stdev: 7.3 ms (4.9%) Runs: 161 157 155 154 154 154 154 153 153 152 150 149 147 146 145 145 143 142 135 132	Baseline Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 Current Mean: 4 Stdev: 0 (0.0%) Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Changes To Render Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 6c41d08

[Xiltyn]

I would say, that it might be a good idea to wait until we merge the other CLI init PR so that we could improve on the warning log at the very least. It will have to be move to the new logger service anyway.

I'm happy to readjust as it's super minor in terms of changes, after the former PR will have been merged.

[mdjastrzebski]

@Xiltyn I think rather than acceping a single file path, we should rather accept a glob that would be somehow passed to Jest for evaluation.

[mdjastrzebski]

Perhaps, we could use the same --testMatch option as Jest.

[thymikee]

Yeah, I'd rather start with proxying testMatch to Jest and when we need to support other test runners some day, we'll rethink this

[Xiltyn]

That's absolutely fair @thymikee @mdjastrzebski. I'll revisit this one and think about a --testMatch based solution instead. Good input!

[mdjastrzebski]

It seems that Jest accepts an array of globs, could we support that as well. Yargs seems to support array type.
https://jestjs.io/docs/cli#--testmatch-glob1--globn

[Xiltyn]

Yes, but we're currently using a single string so I went with the current pattern and added an improvement issue to actually properly update and optimise the glob that we're using as default. Please see #363

[Xiltyn]

I would like to make a separate PR to adjust that and also introduce the __perf__ directory as it would reflect the Jest defaults better.

[thymikee]

I'm good with separate PR, let's not block this

[mdjastrzebski]

@Xiltyn this looks simple and elegant. I've left some minor comments connected with matching Jest options slightly more closely.

[Xiltyn]

@mdjastrzebski @thymikee I updated the PR based on the suggestions. It's mainly a stylistic change since we've already been using the --testMatch option underneath anyway. It should be clearer now though.

[thymikee]

Needs rebase

[Xiltyn]

Needs rebase

Done 👍