Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate branch and commit hash CLI options #211

Merged

Conversation

ShaswatPrabhat
Copy link
Contributor

PR for issue

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022

🦋 Changeset detected

Latest commit: 8f84703

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@callstack/reassure-cli Minor
reassure Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShaswatPrabhat Thanks for the PR., the code looks promising. I think that we can simplify the things a lot by using async/await instead of then() & callbacks. Pls check the comments for details.

.changeset/slow-dolphins-shop.md Outdated Show resolved Hide resolved
packages/reassure-cli/src/commands/measure.ts Outdated Show resolved Hide resolved
Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another contribution @ShaswatPrabhat
I've made a few small improvements before merging, and I will release next minor version soon.

@mdjastrzebski mdjastrzebski merged commit 067f66d into callstack:main Oct 5, 2022
@ShaswatPrabhat ShaswatPrabhat deleted the feat/automate-git-branch-detection branch October 5, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants