Fail the CI measure process if jest fails #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d07c24a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
zacharyfmarion
commented
Sep 19, 2022
mdjastrzebski
requested changes
Sep 19, 2022
|
@mdjastrzebski thanks for the quick review - addressed feedback! |
thymikee
approved these changes
Sep 20, 2022
mdjastrzebski
approved these changes
Sep 26, 2022
There was a problem hiding this comment.
Looks good! @zacharyfmarion thanks for your contribution 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the exit code from the jest spawned process to fail the reassure job if jest errors out. Our performance tests were silently failing since jest was failing to properly render the components. See #171
Test plan
I tested locally by manually throwing an error in a test and running reassure.