feat: add slider limits to web #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a lower/upper limit example to web example
- lower/upp limit variable is optional - fix computation of newValue - add if-else case for lower/upper limits - remove layout changes from commit 641995f
BartoszKlonowski
approved these changes
Dec 22, 2023
MR: refactor valueAfterUpperLimit to valueInLimitRange Co-authored-by: Bartosz Klonowski <[email protected]>
linting corrections Co-authored-by: Bartosz Klonowski <[email protected]>
linting corrections Co-authored-by: Bartosz Klonowski <[email protected]>
linting corrections Co-authored-by: Bartosz Klonowski <[email protected]>
|
I'm not sure how to fix the Lint issue |
|
@JacobDel Normally you should run |
|
Do you have an estimate when this would be released? |
|
Hello @JacobDel! Most probably next Friday (23.02). |
|
Hi, any updates on this? Is there a way to build and use it locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues on abandoned PR: #520
Summary:
Add upperLimit support and lowerLimit support to web.
Test Plan:
Also added an example to the web-example project.
https://github.com/callstack/react-native-slider/assets/38087818/32c09f40-cbc4-4dec-ba51-0cda036ef442