Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): utility type removed from RN 0.71 #486

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

alpha0010
Copy link
Contributor

Summary:

Updating to react native 0.71, TypeScript errors on this library. The utility type Constructor is private in latest typings. Using this export degrades to any type.

JSX element class does not support attributes because it does not have a 'props' property.

Test Plan:

npx tsc runs clean after making this change on a RN 0.71 app.

Copy link
Member

@BartoszKlonowski BartoszKlonowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's have that! Thank you!

@BartoszKlonowski BartoszKlonowski merged commit b8890ca into callstack:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supposedly missing typescript support (JSX element class does not support attributes...)
5 participants